On Mon, Aug 26, 2024 at 11:38 PM Dominique Martinet <asmadeus@xxxxxxxxxxxxx> wrote: > > Steve French wrote on Mon, Aug 26, 2024 at 11:27:33PM -0500: > > I have also confirmed your theory that the regressions (there are > > multiple) were likely caused by the netfs change added between > > 6.11-rc3 and 6.11-rc4: > > " 9p: Fix DIO read through netfs" > > > > But reverting the cifs.ko part of that patch alters the error but does > > not completely fix the problem, so the netfs change is also related > > David sent a bunch of cifs fixes including this patch: > https://lore.kernel.org/r/20240823200819.532106-8-dhowells@xxxxxxxxxx > "netfs, cifs: Fix handling of short DIO read" > > > I don't have any samba server around to try myself, did you have a > chance to have a look? Yes - I just verified that David's latest branch does fix the problem you reported (ie "cat foo" and "xxd foo" on mounts to Samba) I ran with 12 patches (listed below) of David on top of 6.11-rc5 (and 3 unrelated patches from my for-next branch), but most of his patches are not in linux-next yet 540511907bbf (HEAD -> for-next, origin/for-next, origin/HEAD) netfs, cifs: Fix handling of short DIO read 76b6078dcc72 cifs: Fix lack of credit renegotiation on read retry de7b2d4f8789 netfs: Fix interaction of streaming writes with zero-point tracker 0d718d75935d netfs: Fix missing iterator reset on retry of short read eb54e19d9cb8 netfs: Fix trimming of streaming-write folios in netfs_inval_folio() b10b7505454c netfs: Fix netfs_release_folio() to say no if folio dirty 5fee95cba515 mm: Fix missing folio invalidation calls during truncation 68c4ccecdf68 backing-file: convert to using fops->splice_write 65a5aad19a17 Revert "pidfd: prevent creation of pidfds for kthreads" 3e99ab871c90 netfs, ceph: Partially revert "netfs: Replace PG_fscache by setting folio->private and marking dirty" 06f646e2d0d4 netfs, cifs: Improve some debugging bits 416871f4fb84 cifs: Fix FALLOC_FL_PUNCH_HOLE support 017d17017436 smb/client: fix rdma usage in smb2_async_writev() b608e2c31878 smb/client: remove unused rq_iter_size from struct smb_rqst c724b2ab6a46 smb/client: avoid dereferencing rdata=NULL in smb2_new_read_req() -- Thanks, Steve
