On Mon, 26. Aug 09:37, Lokesh Gidra wrote: > > IMHO, within LRU_INACTIVE_FILE, MADV_FREE'ed pages should be > prioritized for reclamation over file ones. > > > > Adding Lokesh. > > Lokesh, could you please comment on the reasoning behind the above > > mentioned change? > > Adding Nicolas as well, in case he wants to add something. IMHO, lruvec_add_folio is enough. if lruvec_add_folio_tail why not use MADV_DONTNEED instead? In MM the reclaim policy prefer to reclaim file cache, if MADV_FREE'd pages directly add to the tail, they might be reclaimed instantly. Also the benefit of workingset_refault_file cannot be convinced for me. So we should know the reasons and the benefits of the changes. page faults or ? > > > > > > > > > > > > > -- > > > > Michal Hocko > > > > SUSE Labs > > > > > > > > > > Thanks > > > Barry > -- Help you, Help me, Hailong.