Re: [PATCH v2] vma remove the unneeded avc bound with non-CoWed folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 24, 2024 at 05:26:46PM GMT, Lorenzo Stoakes wrote:
> On Fri, Aug 23, 2024 at 11:02:06PM GMT, Zhiguo Jiang wrote:
> > After CoWed by do_wp_page, the vma established a new mapping relationship
> > with the CoWed folio instead of the non-CoWed folio. However, regarding
> > the situation where vma->anon_vma and the non-CoWed folio's anon_vma are
> > not same, the avc binding relationship between them will no longer be
> > needed, so it is issue for the avc binding relationship still existing
> > between them.
> >
> > This patch will remove the avc binding relationship between vma and the
> > non-CoWed folio's anon_vma, which each has their own independent
> > anon_vma. It can also alleviates rmap overhead simultaneously.
> >
> > Signed-off-by: Zhiguo Jiang <justinjiang@xxxxxxxx>
>
>
> NACK (until fixed). This is broken (see below).
>

[snip]

I enclose a patch that fixes the issue, but leaves a LOT still
broken/resolved/todo including locking of the reparented anon_vma (that'll
really need re-rooting too).

I still seriously doubt the value of this patch given the complexity risks,
but since I got bored and looked into this it's useful to examine something
that works, and which might be helpful to you in testing.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux