On 8/22/24 07:36, Christoph Hellwig wrote:
On Thu, Aug 22, 2024 at 04:35:57AM +0100, Pavel Begunkov wrote:
Add yet another io_uring cmd implementing async secure erases.
It has same page cache races as async discards and write zeroes and
reuses the common paths in general.
How did you test this? Asking because my interruption fix for secure
In short I didn't, exactly because it's a challenge finding
anything that supports it. At least the change here is minimal,
but ...
discard is still pending because I could not find a test environment
for it. And also because for a "secure" [1] erase proper invalidation
of the page cache actually matters, as otherwise you can still leak
data to the device.
[2] LBA based "secure" erase can't actually be secure on any storage
device that can write out of place. Which is all of flash, but also
modern HDDs when encountering error. It's a really bad interface
we should never have have started to support.
... I should just drop it, not like async support makes much
sense.
--
Pavel Begunkov
