> -----Original Message----- > From: Nhat Pham <nphamcs@xxxxxxxxx> > Sent: Wednesday, August 21, 2024 12:24 PM > To: Sridhar, Kanchana P <kanchana.p.sridhar@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; > hannes@xxxxxxxxxxx; yosryahmed@xxxxxxxxxx; ryan.roberts@xxxxxxx; > Huang, Ying <ying.huang@xxxxxxxxx>; 21cnbao@xxxxxxxxx; akpm@linux- > foundation.org; Zou, Nanhai <nanhai.zou@xxxxxxxxx>; Feghali, Wajdi K > <wajdi.k.feghali@xxxxxxxxx>; Gopal, Vinodh <vinodh.gopal@xxxxxxxxx> > Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is > not defined. > > On Tue, Aug 20, 2024 at 3:50 PM Kanchana P Sridhar > <kanchana.p.sridhar@xxxxxxxxx> wrote: > > > > This resolves an issue with obj_cgroup_get() not being defined > > if CONFIG_MEMCG is not defined. This causes build errors if > > obj_cgroup_get() is called from code that is agnostic of CONFIG_MEMCG. > > > > The patch resolves this. > > > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@xxxxxxxxx> > > --- > > This is only exposed because of your zswap mTHP patch series right? > Could you include this patch as part of that series (since we don't > need this without that patch series), or make it clear in the change > log? That's correct, Nhat. Although, it might be useful to have obj_cgroup_get() defined in the case where CONFIG_MEMCG is not defined. memcontrol.h handles obj_cgroup_put() similarly. Would it be Ok if I included a reference to the zswap mTHP patch series in the change log? Thanks, Kanchana
