On 8/20/24 16:31, Linus Torvalds wrote: > On Tue, 20 Aug 2024 at 14:17, Rob Landley <rob@xxxxxxxxxxx> wrote: >> >> Hexagon also has &&vdso_page which I don't understand (but have a toolchain for >> somewhere to at least smoketest...) > > The '&&' is just a typo. It should obviously be just a single '&'. As > mentioned, the only testing that patch got was a x86-64 UML build > test. > > Fixed locally. I deleted the extra ; and arch/sh4 built and qemu-system-sh4 booted to shell prompt: Freeing initrd memory: 556K Freeing unused kernel image (initmem) memory: 132K This architecture does not have kernel memory protection. Run /init as init process 8139cp 0000:00:02.0 eth0: link up, 100Mbps, full-duplex, lpa 0x05E1 Type exit when done. # cat /proc/version Linux version 6.11.0-rc4 (landley@driftwood) (sh4-linux-musl-gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.33.1) #1 Tue Aug 20 16:45:25 CDT 2024 # head -n 3 /proc/cpuinfo machine : RTS7751R2D processor : 0 cpu family : sh4 Tested-by: Rob Landley <rob@xxxxxxxxxxx> Rob
