Re: [PATCH v3 1/4] kbuild: rust: Define probing macros for rustc

Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> · Tue, 20 Aug 2024 16:20:11 +0200

Hi Matthew,

On Mon, Aug 19, 2024 at 11:35 PM Matthew Maurer <mmaurer@xxxxxxxxxx> wrote:
>
> Creates flag probe macro variants for `rustc`. These are helpful
> because:
>
> 1. `rustc` support will soon be a minimum rather than a pinned version.
> 2. We already support multiple LLVMs linked into `rustc`, and these are
>    needed to probe what LLVM parameters `rustc` will accept.
>
> Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>

I had some feedback on v2 -- was it missed?

    https://lore.kernel.org/rust-for-linux/CANiq72khUrha-a+59KYZgc63w-3P9=Dp_fs=+sgmV_A17q+PTA@xxxxxxxxxxxxxx/

Thanks!

Cheers,
Miguel