On 8/20/24 12:40 PM, Andrew Morton wrote: > On Mon, 19 Aug 2024 19:26:28 +0800 alexs@xxxxxxxxxx wrote: > >> From: Alex Shi <alexs@xxxxxxxxxx> >> >> Remove unnecessary '<' check for ZONES_SHIFT assignment. >> >> ... >> >> --- a/include/linux/page-flags-layout.h >> +++ b/include/linux/page-flags-layout.h >> @@ -14,7 +14,7 @@ >> */ >> #if MAX_NR_ZONES < 2 >> #define ZONES_SHIFT 0 >> -#elif MAX_NR_ZONES <= 2 >> +#elif MAX_NR_ZONES == 2 >> #define ZONES_SHIFT 1 >> #elif MAX_NR_ZONES <= 4 >> #define ZONES_SHIFT 2 > > mmm, why. I think it looks more logical (and certainly more > consistent) the way things are now. > Uh, then let's keep the current code if the logical looks better. In fact, the logical is in preprocess, has nothing change in the final object file. Thanks for comments!
