>On Tue, Aug 20, 2024 at 09:53:11AM +0800, zhangchun wrote: >> kmap_high is defined as EXPORT_SYMBOL, and cannot be called from >> atomic context. Add might_sleep check is necessary. >No. Nobody should be calling kmap_high() directly. There's already a >might_sleep() in kmap(). No need to add one in kmap_high(). To avoid anyone calls kmap_high directly, add function description "Don't use kmap_high directly, if necessary, please use kmap" Signed-off-by: zhangchun <zhang.chuna@xxxxxxx> -- 1.8.3.1