On Wed, Aug 14, 2024 at 06:16:34PM +0200, Miguel Ojeda wrote: > On Wed, Aug 14, 2024 at 6:02 PM Miguel Ojeda > <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > > > I checked about `__must_check`, because it would be nice if it is used > > by `bindgen`, and it turns out it already does, but behind > > `--enable-function-attribute-detection` (apparently for performance > > reasons): > > I just tried, and the flag seems to work, gives us a bunch of > `#[must_use]`s which are nice, and apparently no other change (in > usual x86_64 config at least). Cool! That's even better then. > > I don't notice any significant performance difference in our case, so > I will send a quick patch to see if others find an issue with it. > > Cheers, > Miguel >