Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
From: Yafang Shao <laoar.shao@xxxxxxxxx>
Date: Wed, 14 Aug 2024 15:33:54 +0800
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, jack@xxxxxxx, david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>
In-reply-to: <ZrxASkumlaXWftJ8@infradead.org>
References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> <Zrn0FlBY-kYMftK4@infradead.org> <CALOAHbBd2oCVKsMwcH_YGUWT5LGLWmNSUAZzRPp8j7bBaqc1PQ@mail.gmail.com> <ZroMalgcQFUowTLX@infradead.org> <CALOAHbC=fB0h-YgS9Fr6aTavhPFWKLJzzfM4huYjVaa9+97Y4g@mail.gmail.com> <ZrxASkumlaXWftJ8@infradead.org>

On Wed, Aug 14, 2024 at 1:27 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > There are already memalloc_noreclaim_{save,restore} which imply __GFP_MEMALLOC:
> >
> >   memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope.
>
> .. and those are horrible misnamed :(

What about renaming it to memalloc_memalloc_save ?

>
> If we can't even keep our APIs consistently name, who is supposed
> to understand all this?
>

-- 
Regards
Yafang

References:
- [PATCH 0/2] mm: Add readahead support for IOCB_NOWAIT
  - From: Yafang Shao
- [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Yafang Shao
- Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Christoph Hellwig
- Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Yafang Shao
- Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Christoph Hellwig
- Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Yafang Shao
- Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
  - From: Christoph Hellwig

Prev by Date: [PATCH v1 2/2] mseal: refactor mremap to remove can_modify_mm
Next by Date: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
Previous by thread: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
Next by thread: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore}
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]