On Mon, Aug 12, 2024 at 08:53:06PM +1200, Barry Song wrote:
> On Mon, Aug 12, 2024 at 8:27 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> I assume you mean the below?
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> static struct folio *alloc_swap_folio(struct vm_fault *vmf)
> {
> }
> #else
> static struct folio *alloc_swap_folio(struct vm_fault *vmf)
> {
> }
> #endif
Yes.
> If so, this is fine to me. the only reason I am using the current
> pattern is that i am trying to follow the same pattern with
>
> static struct folio *alloc_anon_folio(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> #endif
> ...
> }
>
> Likely we also want to change that one?
It would be nice to fix that a well, probably noy in this series,
though.
