On Mon, Aug 6, 2012 at 7:22 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote: >> +static inline void > > I would make that __always_inline, just to make sure GCC doesn't go > creative on us. How strongly do you care ? I'm not sure it makes sense to change it unless we also change every other inline function in that file. I'd rather not do that until we hear of gcc actually breaking things. (BTW, did you know that sometimes gcc generates different code when you change from inline to always_inline, even though things were already inlined before ? I really hate dealing with gcc crap like that, makes me want to forget about inline functions and just do it all with preprocessor abuse...) -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>