Re: [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
> +void __rb_insert_augmented(struct rb_node *node, struct rb_root *root,
> +       void (*augment_rotate)(struct rb_node *old, struct rb_node *new))
> +{
> +       __rb_insert(node, root, augment_rotate);
> +}
> +EXPORT_SYMBOL(__rb_insert_augmented);
> +
> +void rb_erase_augmented(struct rb_node *node, struct rb_root *root,
> +                       const struct rb_augment_callbacks *augment)
> +{
> +       __rb_erase(node, root, augment);
> +}
> +EXPORT_SYMBOL(rb_erase_augmented); 

>From a symmetry POV I'd say have both take the rb_augment_callbacks
thing. The two taking different arguments is confusing at best.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]