On Wed, Aug 7, 2024 at 6:41 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, 7 Aug 2024 04:44:44 +0800 Barry Song <21cnbao@xxxxxxxxx> wrote: > > > > > +static bool try_batch_swap_entries_free(struct swap_info_struct *p, > > > > > > Why call it "p" here and not "si" like in the other code you are touching? > > > > that is because I found other _free_ functions are all using "p": > > `p' sucks. "pointer to something". It's just lazy. In this context, "si" > has meaning; lots of it. Agreed. I'll also clean up the existing "p" in those _free_ functions while sending v2. Thanks Barry
