Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Subject: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 5 Aug 2024 19:17:04 -0700
Cc: Jeff Xu <jeffxu@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Pedro Falcato <pedro.falcato@xxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>, Jeff Xu <jeffxu@xxxxxxxxxxxx>, oe-lkp@xxxxxxxxxxxxxxx, lkp@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Guenter Roeck <groeck@xxxxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Jorge Lucangeli Obes <jorgelo@xxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>, Stephen Röttger <sroettger@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Amer Al Shanawany <amer.shanawany@xxxxxxxxx>, Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, ying.huang@xxxxxxxxx, feng.tang@xxxxxxxxx, fengwei.yin@xxxxxxxxx
In-reply-to: <87o766iehy.fsf@mail.lhotse>
References: <202408041602.caa0372-oliver.sang@intel.com> <CAHk-=whbxLj0thXPzN9aW4CcX1D2_dntNu+x9-8uBakamBggLA@mail.gmail.com> <CAKbZUD3B03Zjex4STW8J_1VJhpsYb=1mnZL2-vSaW-CaZdzLiA@mail.gmail.com> <CALmYWFuXVCvAfrcDOCAR72z2_rmnm09QeVVqdhzqjF-fZ9ndUA@mail.gmail.com> <CAHk-=wgPHCJ0vZMfEP50VPjSVi-CzL0fhTGXgNLQn=Pp9W0DVA@mail.gmail.com> <CAHk-=wgdTWpCqTMgM9SJxG2=oYwhAueU_fDHMPifjpH5eHG8qw@mail.gmail.com> <87o766iehy.fsf@mail.lhotse>

On Mon, 5 Aug 2024 at 19:14, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>
> Needs a slight tweak to compile, vvar_close() needs to return void.

Ack, shows just how untested it was.

> And should probably be renamed vdso_close().

.. and that was due to the initial confusion that I then fixed, but
didn't fix the naming.

So yes, those fixes look ObviouslyCorrect(tm).

           Linus

Follow-Ups:
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Michael Ellerman

References:
- [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: kernel test robot
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Linus Torvalds
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Pedro Falcato
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Jeff Xu
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Linus Torvalds
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Linus Torvalds
- Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
  - From: Michael Ellerman

Prev by Date: [PATCH v5 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
Next by Date: [PATCH v5 02/21] mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage()
Previous by thread: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
Next by thread: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]