On 31.07.24 07:13, Kefeng Wang wrote:
On 2024/7/30 18:31, David Hildenbrand wrote:
On 25.07.24 03:16, Kefeng Wang wrote:
Move isolate_hugetlb() after grab a reference, and use the
isolate_folio_to_list() to unify hugetlb/LRU/non-LRU folio
isolation, which cleanup code a bit and save a few calls to
compound_head().
Will this work with free hugetlb folios that have a refcount of 0 and
get_page_unless_zero() would fail?
Before this changes, isolate_hugetlb() will fail to isolate a ref=0
folio(call folio_try_get()) and now get_page_unless_zero() will fail
too, so no behavior change, maybe I miss something?
Good point, isolate_hugetlb() will simply do nothing and we skip the
folio for this round. Let me take a closer look.
--
Cheers,
David / dhildenb
