On Thu 01-08-24 11:32:25, yangerkun wrote: > Hi! > > 在 2024/7/31 22:16, Christian Brauner 写道: > > On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: > > > After we switch tmpfs dir operations from simple_dir_operations to > > > simple_offset_dir_operations, every rename happened will fill new dentry > > > to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free > > > key starting with octx->newx_offset, and then set newx_offset equals to > > > free key + 1. This will lead to infinite readdir combine with rename > > > happened at the same time, which fail generic/736 in xfstests(detail show > > > as below). > > > > > > [...] > > > > @Chuck, @Jan I did the requested change directly. Please check! > > Thanks for applied this patch, the suggestions from Jan and Chuck will > be a separates patch! Christian already updated the patch as I've suggested so no need for you to send anything. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
