On Fri, Jul 26, 2024 at 09:46:15PM +1200, Barry Song wrote: > +static inline int swapcache_prepare(swp_entry_t entry) > +{ > + return swapcache_prepare_nr(entry, 1); > +} Same comment as 2/4 -- there are only two callers of swapcache_prepre(). Just make that take the 'nr' argument and change both callers to pass 1.