On Mon, Jul 29, 2024 at 3:43 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Mon, Jul 29, 2024 at 02:02:22PM +1200, Barry Song wrote:
> > -void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry);
> > +
> > +void mem_cgroup_swapin_uncharge_swap_nr(swp_entry_t entry, unsigned int nr_pages);
> [...]
> > +static inline void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry)
> > +{
> > + mem_cgroup_swapin_uncharge_swap_nr(entry, 1);
> > +}
>
> There are only two callers of mem_cgroup_swapin_uncharge_swap! Just
> add an argument to mem_cgroup_swapin_uncharge_swap() and change the two
> callers. It would be _less_ code than this extra wrapper, and certainly
> less confusing.
sounds good to me. I can totally drop this wrapper -
mem_cgroup_swapin_uncharge_swap()
in v6.
Thanks
Barry
