Re: [PATCH v5 3/4] mm: support large folios swapin as a whole for zRAM-like swapfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 26, 2024 at 09:46:17PM +1200, Barry Song wrote:
> -			folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0,
> -						vma, vmf->address, false);
> +			folio = alloc_swap_folio(vmf);
>  			page = &folio->page;

This is no longer correct.  You need to set 'page' to the precise page
that is being faulted rather than the first page of the folio.  It was
fine before because it always allocated a single-page folio, but now it
must use folio_page() or folio_file_page() (whichever has the correct
semantics for you).

Also you need to fix your test suite to notice this bug.  I suggest
doing that first so that you know whether you've got the calculation
correct.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux