On Sun, 28 Jul 2024 at 13:10, David Laight <David.Laight@xxxxxxxxxx> wrote: > > I think they just need to be MIN_CONST() (without the casts). I'll just convert the existing cases of min_t/max_t to MIN_T/MAX_T, which I already added for other reasons anyway. That makes min_t/max_t not have to care about the nasty special cases (really just array sizes in these cases, and they all wanted MAX_T). > But (as you said earlier in the year) that should just be MIN(). > Except there are a few places that is used that need changing first. Yeah, we should just do this for MIN/MAX too, but that's slightly more annoying because those names are in use and defined by several drivers. Which makes it more of a clean-up. But I'm inclined to just do that too. Bite the bullet, get rid of the whole "has to be a C constant expression" pain. Linus