On Sat, 27 Jul 2024 at 12:01, Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote: > > > > -#define MVPP2_SKB_HEADROOM min(max(XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > > +#define MVPP2_SKB_HEADROOM > > > MIN_T(int,MAX_T(int,XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > Yeah sorry just saw you had already addresed this Linus... I just went with a > clamp()_t in my patch. I think your patch is better. I threw away my disgusting MIN_T() thing here. It made more sense in pageblock-flags.h where it replaced "min_t()". Linus