Re: [PATCH 3/4] mm: migrate: add isolate_folio_to_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/7/26 22:21, kernel test robot wrote:
Hi Kefeng,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-memory-failure-add-unmap_posioned_folio/20240725-091923
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240725011647.1306045-4-wangkefeng.wang%40huawei.com
patch subject: [PATCH 3/4] mm: migrate: add isolate_folio_to_list()
config: x86_64-randconfig-004-20240726 (https://download.01.org/0day-ci/archive/20240726/202407262129.FJbkroy1-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240726/202407262129.FJbkroy1-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407262129.FJbkroy1-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

    ld: mm/memory-failure.o: in function `mf_isolate_folio':
mm/memory-failure.c:2662:(.text+0x2e8a): undefined reference to `isolate_folio_to_list'



OK, no CONFIG_MIGRATION, will fix in next version,

vim +2662 mm/memory-failure.c

   2659	
   2660	static bool mf_isolate_folio(struct folio *folio, struct list_head *pagelist)

and will kill mf_ioslate_folio() too, we could directly use isolate_folio_to_list() in soft_offline_in_use_page().


Thanks.

   2661	{
2662		bool isolated = isolate_folio_to_list(folio, pagelist);
   2663	
   2664		/*
   2665		 * If we succeed to isolate the folio, we grabbed another refcount on
   2666		 * the folio, so we can safely drop the one we got from get_any_page().
   2667		 * If we failed to isolate the folio, it means that we cannot go further
   2668		 * and we will return an error, so drop the reference we got from
   2669		 * get_any_page() as well.
   2670		 */
   2671		folio_put(folio);
   2672		return isolated;
   2673	}
   2674	





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux