On 08/02/2012 06:11 PM, Christoph Lameter wrote:
> On Thu, 2 Aug 2012, Glauber Costa wrote:
>
>> On 08/02/2012 01:11 AM, Christoph Lameter wrote:
>>> + if (!s->name) {
>>> + kmem_cache_free(kmem_cache, s);
>>> + s = NULL;
>>> + goto oops;
>>> + }
>>> +
>> This is now only defined when CONFIG_DEBUG_VM. Now would be a good time
>> to fix that properly by just removing the ifdef around the label.
>
> I disagree with randomly adding checks to production code. These are
> things useful for debugging but should not increase the cahce footprint of
> the kernel in production system.
>
>
Read again, this has nothing to do with adding code to production kernel.
You are actually jumping to a non-existant label when CONFIG_DEBUG_VM,
so this is a build failure.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>