When a page_counter structure is initialized, there is no need to use an atomic set operation to initialize usage counters because at this point the structure is not visible to anybody else. ATOMIC_LONG_INIT() is what should be used in such cases. Signed-off-by: Roman Gushchin <roman.gushchin@xxxxxxxxx> --- include/linux/page_counter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h index 701e1255c456..ee740ed8cb90 100644 --- a/include/linux/page_counter.h +++ b/include/linux/page_counter.h @@ -114,7 +114,7 @@ static inline void page_counter_init(struct page_counter *counter, unsigned long i; for (i = 0; i < MCT_NR_ITEMS; i++) { - atomic_long_set(&counter->usage[i], 0); + counter->usage[i] = (atomic_long_t)ATOMIC_LONG_INIT(0); counter->max[i] = PAGE_COUNTER_MAX; } counter->parent = parent; -- 2.46.0.rc1.232.g9752f9e123-goog