On Tue, 23 Jul 2024 at 18:05, Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote: > > There were four pulls I had to wait for before I could send this to you, > but PG_error is now unused and can be reclaimed. It could wait until > next merge window, but I don't see the point. Well, I was initially inclined to agree with that, but then I did a test-compile, and that immediately notices that you never tested this at all and that it's completely broken. There's still uses of PG_error in fs/proc/page.c, and in include/trace/events/mmflags.h, and neither of those two cases are new. One is unchanged from 2009, and the other one has gone through a few code movements and re-orgs but also goes back over a decade ago. So clearly this needs to be in linux-next, and as such this very much is "next merge window". Linus