On Tue, Jul 23, 2024 at 12:25:51PM GMT, Mike Rapoport wrote:
> On Mon, Jul 22, 2024 at 12:50:24PM +0100, Lorenzo Stoakes wrote:
> > The core components contained within the radix-tree tests which provide
> > shims for kernel headers and access to the maple tree are useful for
> > testing other things, so separate them out and make the radix tree tests
> > dependent on the shared components.
> >
> > This lays the groundwork for us to add VMA tests of the newly introduced
> > vma.c file.
> >
> > Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> > Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> > ---
> > tools/testing/radix-tree/Makefile | 68 +++----------------
> > tools/testing/radix-tree/maple.c | 15 +---
> > tools/testing/radix-tree/xarray.c | 10 +--
> > tools/testing/shared/autoconf.h | 2 +
> > tools/testing/{radix-tree => shared}/bitmap.c | 0
> > tools/testing/{radix-tree => shared}/linux.c | 0
>
> maybe tools/testing/lib
>
> > .../{radix-tree => shared}/linux/bug.h | 0
>
> and tools/testing/include?
>
Right, I was also wondering how best to integrate tools/include (and by
that token, tools/lib) but there are some fiddly include path precedence
tricks used by the various Makefile's that might have made this break
things.
Additionally I think it'd cause some confusion to have tools/include and
tools/testing/include when tools/include is used by a bunch of testing...
So I propose we take a look at seeing if we can't just integrate
tools/include and tools/lib in a follow-up series? (maybe these should
actually be in tools/testing/... too, not sure if there are other tools
that use them as-is).
This one is making a one-shot super conflict-y bunch of changes to mm/ code
I think it's best to get it in asap, it'll be far easier to make changes to
tools/ stuff in isolation later.
>
> --
> Sincerely yours,
> Mike.
