On Wed, Jul 17, 2024 at 07:53:23PM -0700, Andrew Morton wrote: > Removed by which commit? Thanks. This was removed in: 88dca4ca5a93 mm: remove the pgprot argument to __vmalloc It was removed because every driver was passing PAGE_KERNEL > Why does this driver need a thing which no other driver does? You can find more information in the manufacturer's docs: https://www.congatec.com/fileadmin/user_upload/Documents/Manual/CGOSAPI.pdf In particular, section 1 (page 11) describes how they intend for it to work. Basically, they provide an x86 blob in the BIOS that we copy into kernelspace and mark executable. Then, we can call into that blob to access congatec's special hardware. Thanks again for reviewing my patches! If there is a better way to do what I'm trying to do, please let me know. It's possible I'm missing something obvious.