On 7/17/24 10:04 PM, Suren Baghdasaryan wrote:
> On Wed, Jul 17, 2024 at 12:36 PM Vlastimil Babka <vbabka@xxxxxxx> wrote:
>>
>> On 7/17/24 8:12 PM, Suren Baghdasaryan wrote:
>> > Outline and export free_reserved_page() because modules use it and it
>> > in turn uses page_ext_{get|put} which should not be exported. The same
>> > result could be obtained by outlining {get|put}_page_tag_ref() but that
>> > would have higher performance impact as these functions are used in
>> > more performance critical paths.
>> >
>> > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging")
>> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@xxxxxxxxx/
>> > Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>> > Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
>> > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>>
>> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>>
>> Are these two patches now stable@ material as 6.10 build is broken on ppc64
>> with alloc taging enabled?
>
> I tested them with that specific configuration mentioned in the bug
> report and with several usual ones I use.
> Yeah, I guess from now on all such fixes should have
>
> Cc: stable@xxxxxxxxxxxxxxx # v6.10
Right. BTW I have just realized that the way you did Patch 2/2 and outlined
the whole free_reserved_page() (which is fair, it's an init-time function),
mem_alloc_profiling_enabled() didn't stay inlined so Patch 1/2 is in fact
not necessary anymore?
