Hi Hugh, On Tue, Jul 31, 2012 at 10:34 AM, Hugh Dickins <hughd@xxxxxxxxxx> wrote: > But I can see that the lack of reinitialization of entry.val here > does raise doubt and confusion. A better tidyup would be to remove > the initialization of swp_entry_t entry from its onstack declaration, > and do it at the again label instead. I just want to avoid allocating page in add_swap_count_continuation() for non clear reason, as you see, which is not a bug fix. Thanks, Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>