On Tue, Jul 09, 2024 at 02:35:16PM GMT, Liam R. Howlett wrote: [snip] > > > > Maybe I should literally look ahead before making comments :)) thanks for > > reading my mind and doing what I asked though! ;) > > > > However I don't think you've fixed the duplication of PHYS_PFN(vm_end - > > vm_start) in count_vma_pages_range() - still worth doing I think. > > I drop that function in the last patch so probably not worth doing. > This is just a few patches before the axe drops. > Actually that's a fair point - I think its fine to do without this nit with that context! This is the peril of reviewing forwards through the series and being surprised later when things are addressed in subsequent patches (or become, ultimately, irrelevant!). > > > > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
