On Tue, 2 Jul 2024 16:04:02 +0800 Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote: > >> Tasks might not be killed even to_kill struct is allocated. > >> > >> ... > >> > >>> - raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC); > >>> + raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC | __GFP_MEMALLOC); > >> > >> In already hardware poisoned code path, raw_hwp can be allocated to store raw page info > >> without killing anything. So __GFP_MEMALLOC might not be suitable to use. > >> Or am I miss something? > > > > Yes, I'm doubtful about this patch. I think that rather than poking at a > > particular implementation, it would be helpful for us to see a complete > > description of the issues which were observed, please. Let's see the > > bug report and we can discuss fixes later. > > I agree with you, Andrew. Thanks. :) I dropped the patch. Please let's proceed as discussed above.
