On Fri, 2012-07-20 at 05:31 -0700, Michel Lespinasse wrote:
> +static inline void
> +rb_erase_augmented(struct rb_node *node, struct rb_root *root,
> + rb_augment_propagate *augment_propagate,
> + rb_augment_rotate *augment_rotate)
So why put all this in a static inline in a header? As it stands
rb_erase() isn't inlined and its rather big, why would you want to
inline it for augmented callers?
You could at least pull out the initial erase stuff into a separate
function, that way the rb_erase_augmented thing would shrink to
something like:
rb_erase_augmented(node, root)
{
struct rb_node *parent, *child;
bool black;
__rb_erase(node, root, &parent, &child, &black);
augmented_propagate(parent);
if (black)
__rb_erase_color(child, parent, root, augment_rotate);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href