On Wed, Jul 3, 2024 at 10:52 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 2 Jul 2024 23:40:07 +0000 Wei Yang <richard.weiyang@xxxxxxxxx> wrote: > > > .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is > > set, since we define MEM_KEEP()/MEM_DISCARD() according to > > CONFIG_MEMORY_HOTPLUG. > > Please describe how this changes modpost behaviour. > > Something like: "we're currently not checking for references into > meminit and meminitdata when CONFIG_HOTPLUG=y, which may cause us to > fail to notice incorrect references.". But I don't think that's > correct. So what *is* wrong with the current code? > Sigh. If you do not understand, you should not apply it. I am surprised that there exists a person who attempted to apply this. -- Best Regards Masahiro Yamada