On 2024/7/2 7:10, Alexander H Duyck wrote: > On Tue, 2024-06-25 at 21:52 +0800, Yunsheng Lin wrote: >> Inspired by [1], move the page fragment allocator from page_alloc >> into its own c file and header file, as we are about to make more >> change for it to replace another page_frag implementation in >> sock.c >> >> 1. https://lore.kernel.org/all/20230411160902.4134381-3-dhowells@xxxxxxxxxx/ >> >> CC: David Howells <dhowells@xxxxxxxxxx> >> CC: Alexander Duyck <alexander.duyck@xxxxxxxxx> >> Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx> > > So one thing that I think might have been overlooked in the previous > reviews is the fact that the headers weren't necessarily self > sufficient. You were introducing dependencies that had to be fulfilled > by other headers. > > One thing you might try doing as part of your testing would be to add a > C file that just adds your header and calls your functions to verify > that there aren't any unincluded dependencies. Sure, will do. >
