On Mon, Jun 24, 2024 at 02:26:54PM GMT, Andrew Morton wrote: > On Tue, 25 Jun 2024 01:53:06 +0800 Kairui Song <ryncsn@xxxxxxxxx> wrote: > > > Currently, every list_lru has a per-node lock that protects adding, > > deletion, isolation, and reparenting of all list_lru_one instances > > belonging to this list_lru on this node. This lock contention is heavy > > when multiple cgroups modify the same list_lru. > > > > This can be alleviated by splitting the lock into per-cgroup scope. > > I'm wavering over this. We're at -rc5 and things generally feel a bit > unstable at present. > > The performance numbers are nice for extreme workloads, but can you > suggest how much benefit users will see in more typical workloads? > > Anyway, opinions are sought and I'd ask people to please review this > work promptly if they feel is it sufficiently beneficial. I will take a look this week (or next) hopefully but I don't see any issue or concern missing the upcoming open window. Shakeel > >