On Mon 24-06-24 17:59:03, Roman Gushchin wrote: > memcg1_update_tree() is not used outside of mm/memcontrol-v1.c > anymore, define it as static and remove the declaration from > the header file. > > Signed-off-by: Roman Gushchin <roman.gushchin@xxxxxxxxx> Acked-by: Michal Hocko <mhocko@xxxxxxxx> > --- > mm/memcontrol-v1.c | 2 +- > mm/memcontrol-v1.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 1b7337d0170d..f89de413004b 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -201,7 +201,7 @@ static unsigned long soft_limit_excess(struct mem_cgroup *memcg) > return excess; > } > > -void memcg1_update_tree(struct mem_cgroup *memcg, int nid) > +static void memcg1_update_tree(struct mem_cgroup *memcg, int nid) > { > unsigned long excess; > struct mem_cgroup_per_node *mz; > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > index 7be4670d9abb..7d6ac4a4fb36 100644 > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -5,7 +5,6 @@ > > #include <linux/cgroup-defs.h> > > -void memcg1_update_tree(struct mem_cgroup *memcg, int nid); > void memcg1_remove_from_trees(struct mem_cgroup *memcg); > > static inline void memcg1_soft_limit_reset(struct mem_cgroup *memcg) > -- > 2.45.2 > -- Michal Hocko SUSE Labs