Re: [PATCH 01/24] uprobes, mm, x86: Add the ability to install and remove uprobes breakpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Torsten,

Just a couple of quick suggestions:

On Tue, 24 Jul 2012 23:12:45 +0200 Torsten Polle <Torsten.Polle@xxxxxx> wrote:
>

Firstly, don't attach patches, put them inline in you email - it makes
it easier for reviewers to comment on them.

> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index c9866b0..1f5c307 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -243,6 +243,9 @@ config ARCH_CPU_PROBE_RELEASE
>  	def_bool y
>  	depends on HOTPLUG_CPU
>  
> +config ARCH_SUPPORTS_UPROBES
> +	def_bool y
> +

You should put this in arch/Kconfig (as just a bool- no default) and
then select it in the x86 Kconfig.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgpem3uJDrYAe.pgp
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]