On Fri, Jun 21, 2024 at 07:51:26AM -0700, Dave Hansen wrote:
> On 6/21/24 07:25, Peter Xu wrote:
> > These new helpers will be needed for pud entry updates soon. Namely:
> >
> > - pudp_invalidate()
> > - pud_modify()
>
> I think it's also definitely worth noting where you got this code from.
> Presumably you copied, pasted and modified the PMD code. That's fine,
> but it should be called out.
Yes that's from PMD ones. Sure, I will add that.
>
> ...
> > +static inline pud_t pud_modify(pud_t pud, pgprot_t newprot)
> > +{
> > + pudval_t val = pud_val(pud), oldval = val;
> > +
> > + /*
> > + * NOTE: no need to consider shadow stack complexities because it
> > + * doesn't support 1G mappings.
> > + */
> > + val &= _HPAGE_CHG_MASK;
> > + val |= check_pgprot(newprot) & ~_HPAGE_CHG_MASK;
> > + val = flip_protnone_guard(oldval, val, PHYSICAL_PUD_PAGE_MASK);
> > +
> > + return __pud(val);
> > +}
>
> First of all, the comment to explain what you didn't do here is as many
> lines as the code to _actually_ implement it.
>
> Second, I believe this might have missed the purpose of the "shadow
> stack complexities". The pmd/pte code is there not to support modifying
> shadow stack mappings, it's there to avoid inadvertent shadow stack
> mapping creation.
>
> That "NOTE:" is ambiguous as to whether the shadow stacks aren't
> supported on 1G mappings in Linux or the hardware (I just checked the
> hardware docs and don't see anything making 1G mappings special, btw).
Right this could be ambiguous indeed; I was trying to refer to the fact
where shadow stack is only supported on anon, and anon doesn't support 1G.
But looks like I'm more than wrong than that..
>
> But, still, what if you take a Dirty=1,Write=1 pud and pud_modify() it
> to make it Dirty=1,Write=0? What prevents that from being
> misinterpreted by the hardware as being a valid 1G shadow stack mapping?
Thanks for pointing that out. I think I was thinking it will only take
effect on VM_SHADOW_STACK first, so it's not?
I was indeed trying to find more information on shadow stack at that time
but I can't find as much on the pgtable implications, on e.g. whether "D=1
+ W=0" globally will be recognized as shadow stack. At least on SDM March
2024 version Vol3 Chap4 pgtable entries still don't explain these details,
or maybe I missed it. Please let me know if there's suggestion on what I
can read before I post a v2.
So if it's globally taking effect, indeed we'll need to handle them in PUDs
too.
Asides, not sure whether it's off-topic to ask here, but... why shadow
stack doesn't reuse an old soft-bit to explicitly mark "this is shadow
stack ptes" when designing the spec? Now it consumed bit 58 anyway for
caching dirty. IIUC we can avoid all these "move back and forth" issue on
dirty bit if so.
>
> > /*
> > * mprotect needs to preserve PAT and encryption bits when updating
> > * vm_page_prot
> > @@ -1377,10 +1398,25 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma,
> > }
> > #endif
> >
> > +static inline pud_t pudp_establish(struct vm_area_struct *vma,
> > + unsigned long address, pud_t *pudp, pud_t pud)
> > +{
> > + if (IS_ENABLED(CONFIG_SMP)) {
> > + return xchg(pudp, pud);
> > + } else {
> > + pud_t old = *pudp;
> > + WRITE_ONCE(*pudp, pud);
> > + return old;
> > + }
> > +}
>
> Why is there no:
>
> page_table_check_pud_set(vma->vm_mm, pudp, pud);
>
> ? Sure, it doesn't _do_ anything today. But the PMD code has it today.
> So leaving it out creates a divergence that honestly can only serve to
> bite us in the future and will create a head-scratching delta for anyone
> that is comparing PUD and PMD implementations in the future.
Good question, I really don't remember why I didn't have that, since I
should have referenced the pmd helper. I'll add them and see whether I'll
hit something otherwise.
Thanks for the review.
--
Peter Xu
