Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yafang Shao <laoar.shao@xxxxxxxxx>
Subject: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Fri, 21 Jun 2024 14:57:07 +0100
Cc: torvalds@xxxxxxxxxxxxxxxxxxxx, ebiederm@xxxxxxxxxxxx, alexei.starovoitov@xxxxxxxxx, rostedt@xxxxxxxxxxx, catalin.marinas@xxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, audit@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20240621022959.9124-7-laoar.shao@gmail.com>
References: <20240621022959.9124-1-laoar.shao@gmail.com> <20240621022959.9124-7-laoar.shao@gmail.com>

On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote:
> +++ b/mm/internal.h

Why are you putting __kstrndup in a header file when it's only used
in util.c?

Also, I think this function is actually __kmemdup_nul(), not
__kstrndup().

Follow-Ups:
- Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
  - From: Yafang Shao

References:
- [PATCH v3 00/11] Improve the copy of task comm
  - From: Yafang Shao
- [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
  - From: Yafang Shao

Prev by Date: [PATCH v7 02/38] kmsan: Make the tests compatible with kmsan.panic=1
Next by Date: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
Previous by thread: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
Next by thread: Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]