On 18 Jun 2024, at 11:10, David Hildenbrand wrote: > Let's simplify and reduce code indentation. In the RMAP_LEVEL_PTE case, we > already check for nr when computing partially_mapped. > > For RMAP_LEVEL_PMD, it's a bit more confusing. Likely, we don't need the > "nr" check, but we could have "nr < nr_pmdmapped" also if we stumbled > into the "/* Raced ahead of another remove and an add? */" case. So > let's simply move the nr check in there. > > Note that partially_mapped is always false for small folios. > > No functional change intended. > > Cc: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > --- > mm/rmap.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx> -- Best Regards, Yan, Zi
Attachment:
signature.asc
Description: OpenPGP digital signature