On 20 Jun 2024, at 17:29, David Hildenbrand wrote: > Let's just return 0 on success, which is less confusing. > > ... especially because we got it wrong in the migrate.h stub where we > have "return -EAGAIN; /* can't migrate now */" instead of "return 0;". > Likely this wrong return value doesn't currently matter, but it > certainly adds confusion. > > We'll add migrate_misplaced_folio_prepare() next, where we want to use > the same "return 0 on success" approach, so let's just clean this up. > > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > --- > mm/huge_memory.c | 5 ++--- > mm/memory.c | 2 +- > mm/migrate.c | 4 ++-- > 3 files changed, 5 insertions(+), 6 deletions(-) > LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx> -- Best Regards, Yan, Zi
Attachment:
signature.asc
Description: OpenPGP digital signature