[linux-next:master 2133/7397] drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ville,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b992b79ca8bc336fa8e2c80990b5af80ed8f36fd
commit: 74bde7581df3e18061119e1b27b63d0a9ea57b7a [2133/7397] drm/sti: Allow build with COMPILE_TEST=y
config: loongarch-randconfig-r071-20240620 (https://download.01.org/0day-ci/archive/20240621/202406210357.uLQ9cfev-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406210357.uLQ9cfev-lkp@xxxxxxxxx/

smatch warnings:
drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting

vim +696 drivers/gpu/drm/sti/sti_hda.c

c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  672  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  673  static int sti_hda_bind(struct device *dev, struct device *master, void *data)
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  674  {
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  675  	struct sti_hda *hda = dev_get_drvdata(dev);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  676  	struct drm_device *drm_dev = data;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  677  	struct drm_encoder *encoder;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  678  	struct sti_hda_connector *connector;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  679  	struct drm_connector *drm_connector;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  680  	struct drm_bridge *bridge;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  681  	int err;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  682  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  683  	/* Set the drm device handle */
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  684  	hda->drm_dev = drm_dev;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  685  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  686  	encoder = sti_hda_find_encoder(drm_dev);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  687  	if (!encoder)
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  688  		return -ENOMEM;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  689  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  690  	connector = devm_kzalloc(dev, sizeof(*connector), GFP_KERNEL);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  691  	if (!connector)
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  692  		return -ENOMEM;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  693  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  694  	connector->hda = hda;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  695  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30 @696  		bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  697  	if (!bridge)
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  698  		return -ENOMEM;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  699  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  700  	bridge->driver_private = hda;
b07b90fd178a47 Ajay Kumar        2015-01-20  701  	bridge->funcs = &sti_hda_bridge_funcs;
a25b988ff83f3c Laurent Pinchart  2020-02-26  702  	drm_bridge_attach(encoder, bridge, NULL, 0);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  703  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  704  	connector->encoder = encoder;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  705  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  706  	drm_connector = (struct drm_connector *)connector;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  707  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  708  	drm_connector->polled = DRM_CONNECTOR_POLL_HPD;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  709  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  710  	drm_connector_init(drm_dev, drm_connector,
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  711  			&sti_hda_connector_funcs, DRM_MODE_CONNECTOR_Component);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  712  	drm_connector_helper_add(drm_connector,
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  713  			&sti_hda_connector_helper_funcs);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  714  
cde4c44d8769c1 Daniel Vetter     2018-07-09  715  	err = drm_connector_attach_encoder(drm_connector, encoder);
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  716  	if (err) {
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  717  		DRM_ERROR("Failed to attach a connector to a encoder\n");
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  718  		goto err_sysfs;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  719  	}
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  720  
9b60514d889a99 Vincent Abriou    2016-02-05  721  	/* force to disable hd dacs at startup */
9b60514d889a99 Vincent Abriou    2016-02-05  722  	hda_enable_hd_dacs(hda, false);
9b60514d889a99 Vincent Abriou    2016-02-05  723  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  724  	return 0;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  725  
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  726  err_sysfs:
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  727  	return -EINVAL;
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  728  }
c86a5f6e1b9c84 Benjamin Gaignard 2014-07-30  729  

:::::: The code at line 696 was first introduced by commit
:::::: c86a5f6e1b9c84064231ec867aca281d9e8514a2 drm: sti: add HDA driver

:::::: TO: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
:::::: CC: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux