Zi Yan <ziy@xxxxxxxxxx> writes: > On 19 Jun 2024, at 3:25, Huang, Ying wrote: > >> Zi Yan <zi.yan@xxxxxxxx> writes: >> >>> From: Zi Yan <ziy@xxxxxxxxxx> >>> >>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to >>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when >>> calling migrate_pages_batch(). > > Because if not, when migrate_pages_batch() is called via > migrate_pages(MIGRATE_ASYNC), nr_thp_failed will not be increased and > when migrate_pages_batch() is called via migrate_pages(MIGRATE_SYNC*), > nr_thp_failed will be increase in migrate_pages_sync() by > stats->nr_thp_failed += astats.nr_thp_split. > >>> >>> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ >> >> IMHO, we shouldn't ask people to use link to understand the patch >> description or commit message. If so, we can make the link less >> outstanding and maybe add more words about the issue. > > I summarized your explanation from the link. You think the summary is not > enough? I can add more text. Let me know if the above text looks > good to you, then I can resend the patch. Thanks. It looks good to me, Thanks! -- Best Regards, Huang, Ying
