Ryan Roberts <ryan.roberts@xxxxxxx> writes: > On 19/06/2024 08:19, Huang, Ying wrote: >> Hi, Ryan, >> >> Ryan Roberts <ryan.roberts@xxxxxxx> writes: >> >>> Hi All, >>> >>> Chris has been doing great work at [1] to clean up my mess in the mTHP swap >>> entry allocator. >> >> I don't think the original behavior is something like mess. It's just >> the first step in the correct direction. It's straightforward and >> obviously correctly. Then, we can optimize it step by step with data to >> justify the increased complexity. > > OK, perhaps I was over-egging it by calling it a "mess". What you're describing > was my initial opinion too, but I saw Andrew complaining that we shouldn't be > merging a feature if it doesn't work. I don't think it doesn't work. It just works well for some workloads, but doesn't work well for some other workloads. We can always improve the implementation to make it works better for more workloads.
