DAMON context struct (damon_ctx) contains user requests (parameters),
internal status, and operation results. For flexible usages, DAMON API
users are encouraged to manually manipulate the struct. That works well
for simple use cases. However, it has turned out that it is not that
simple at least for online parameters udpate. It is easy to forget
properly maintaining internal status and operation results. Also, such
manual manipulation for online tuning is implemented multiple times on
DAMON API users including DAMON sysfs interface, DAMON_RECLAIM and
DAMON_LRU_SORT. As a result, we have multiple sources of bugs for same
problem. Actually we found and fixed a few bugs from online parameter
updating of DAMON API users.
Implement a function for online DAMON parameters update in core layer,
and replace DAMON API users' manual manipulation code for the use case.
The core layer function could still have bugs, but this change reduces
the source of bugs for the problem to one place.
SeongJae Park (12):
mm/damon/core: implement DAMOS quota goals online commit function
mm/damon/core: implement DAMON context commit function
mm/damon/sysfs: use damon_commit_ctx()
mm/damon/sysfs-schemes: use damos_commit_quota_goals()
mm/damon/sysfs: remove unnecessary online tuning handling code
mm/damon/sysfs: rename damon_sysfs_set_targets() to ...add_targets()
mm/damon/sysfs-schemes: remove unnecessary online tuning handling code
mm/damon/sysfs-schemes: rename
*_set_{schemes,scheme_filters,quota_score,schemes}()
mm/damon/reclaim: use damon_commit_ctx()
mm/damon/reclaim: remove unnecessary code for online tuning
mm/damon/lru_sort: use damon_commit_ctx()
mm/damon/lru_sort: remove unnecessary online tuning handling code
include/linux/damon.h | 2 +
mm/damon/core.c | 333 +++++++++++++++++++++++++++++++++++++++
mm/damon/lru_sort.c | 53 +++----
mm/damon/reclaim.c | 62 +++-----
mm/damon/sysfs-common.h | 2 +-
mm/damon/sysfs-schemes.c | 94 +++--------
mm/damon/sysfs-test.h | 10 +-
mm/damon/sysfs.c | 81 +++-------
8 files changed, 425 insertions(+), 212 deletions(-)
base-commit: a7b6f23b7fa3f5d1f3ae64034a4aff12fb8c1df0
--
2.39.2
