On Mon, 17 Jun 2024 at 13:17, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > This patch wasn't even cc'd to linux-mm, so I never saw it. I would > have NAKed it based on this already being fixed. I actually cc'd y ou partly because you were part of that earlier fix, but also because of the implicit question: "So it's very possible that the if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) return 0; test in __thp_get_unmapped_area() should be extended to take requested address randomization into account" and whether we maybe could do better? For x86-64, the default for min compat bits is 28 - which is presumably plenty - but maybe we have issues elsewhere? Linus