On 6/14/24 5:41 AM, David Hildenbrand wrote:
On 14.06.24 14:28, David Hildenbrand wrote:
On 14.06.24 04:30, John Hubbard wrote:
The selftests/mm build isn't exactly "broken", according to the current
documentation, which still claims that one must run "make headers",
before building the kselftests. However, according to the new plan to
get rid of that requirement [1], they are future-broken: attempting to
build selftests/mm *without* first running "make headers" will fail due
to not finding __NR_mseal.
Therefore, add ./usr/include/asm/unistd_[32|x32|64].h (created via
"make headers") to tools/uapi/, and change the selftests/mm files that
require __NR_mseal to include from the correct location. The way to do
so is to include <linux/unistd.h> instead of just <unistd.h>.
[1] commit e076eaca5906 ("selftests: break the dependency upon local
header files")
Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing")
Cc: Jeff Xu <jeffxu@xxxxxxxxxxxx>
Cc: David Hildenbrand <david@xxxxxxxxxx>
Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
---
If it works, great
... thinking again, are some of these headers arch-specific (IOW,
generating them per-arch would result in something slightly different)?
Oh wow, yes they are. I'm guilty of x86-centric thinking (again).
hmm, this is going to make it really a lot of trouble to do this
approach. But there's no point in turning back now, so I guess I'd
better fire up the cross-compilers and generate for all the arches.
In tools/include/uapi/asm-generic/unistd.h, we already do have
__NR_mseal ...
Yes, but it doesn't get used in selftests/mm, with the way headers are
set up right now.
thanks,
--
John Hubbard
NVIDIA
