On 13.06.24 14:43, Lance Yang wrote:
On Thu, Jun 13, 2024 at 4:49 PM Lance Yang <ioworker0@xxxxxxxxx> wrote:
On Thu, Jun 13, 2024 at 4:27 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
On 13.06.24 09:52, Barry Song wrote:
On Tue, Jun 11, 2024 at 12:02 AM Lance Yang <ioworker0@xxxxxxxxx> wrote:
Introduce the labels walk_done and walk_done_err as exit points to
eliminate duplicated exit code in the pagewalk loop.
Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
Signed-off-by: Lance Yang <ioworker0@xxxxxxxxx>
Hi Barry and David,
Thanks for taking time to review!
I don't think "return false" necessarily indicates an error, so
"walk_done_err" doesn't seem like an appropriate name.
However, this is a minor issue.
Agreed. As we only have a single walk_done user, should we instead
remove "walk_done", keep the "page_vma_mapped_walk_done" for that single
user, and rename "walk_done_err" to "abort_walk" ?
Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and let's
keep 'page_vma_mapped_walk_done' for that single user ;)
I just realized that there is another walk_done user, which is
unmap_huge_pmd_locked().
Could I keep "walk_done" but rename it to "done_walk"?
Sure. "walk_done"/"walk_abort" might sound better.
--
Cheers,
David / dhildenb
